Skip to content

chore: skip hmac tests until b/493225655 is fixed#1771

Merged
nidhiii-27 merged 2 commits intomainfrom
skip-hmac-tests
Mar 16, 2026
Merged

chore: skip hmac tests until b/493225655 is fixed#1771
nidhiii-27 merged 2 commits intomainfrom
skip-hmac-tests

Conversation

@nidhiii-27
Copy link
Contributor

@nidhiii-27 nidhiii-27 commented Mar 16, 2026

Skipping hmac tests if they fail with a 412 PreconditionFailed. This is occurring because the testing project python-docs-samples-tests has the constraints/iam.disableServiceAccountKeyCreation Organization Policy enforced.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Mar 16, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 16, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the stability of the test suite by addressing a known issue where HMAC key creation tests fail due to an organizational policy that disables service account key creation. By introducing a mechanism to detect this specific error and conditionally skip the affected tests, the PR ensures that the test suite can continue to run without being blocked by this external configuration, pending a permanent resolution.

Highlights

  • Test Stability: Implemented conditional skipping for HMAC key creation tests to prevent failures caused by a PreconditionFailed error, specifically when the constraints/iam.disableServiceAccountKeyCreation organization policy is enforced.
Changelog
  • samples/snippets/hmac_samples_test.py
    • Removed an unnecessary blank line.
    • Wrapped the create_hmac_key call in a try-except block to catch google.api_core.exceptions.PreconditionFailed.
    • Added logic to skip the test using pytest.skip if the PreconditionFailed error is due to the constraints/iam.disableServiceAccountKeyCreation policy.
    • Simplified the call to storage_create_hmac_key.create_key by removing line breaks.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 16, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds logic to skip HMAC tests when they fail due to a specific organization policy. The implementation in the new_hmac_key fixture is mostly correct, and I've suggested a small improvement for re-raising exceptions to preserve the stack trace. Additionally, test_create_key was missed and will still fail; I've provided a suggestion to apply the same skipping logic there to ensure all relevant tests are skipped as intended.

@nidhiii-27 nidhiii-27 marked this pull request as ready for review March 16, 2026 17:55
@nidhiii-27 nidhiii-27 requested review from a team as code owners March 16, 2026 17:55
@nidhiii-27 nidhiii-27 requested a review from polong-lin March 16, 2026 17:55
@nidhiii-27 nidhiii-27 merged commit 141f7ac into main Mar 16, 2026
15 checks passed
@nidhiii-27 nidhiii-27 deleted the skip-hmac-tests branch March 16, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandra-siri chandra-siri chandra-siri approved these changes

@polong-lin polong-lin Awaiting requested review from polong-lin polong-lin is a code owner automatically assigned from googleapis/python-samples-reviewers

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chandra-siri chandra-siri

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nidhiii-27 @chandra-siri